Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hasse-Schmidt derivatives 2.0 #4272

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

KilianBruns
Copy link

@KilianBruns KilianBruns commented Nov 5, 2024

This is a new version of the abbandoned pull request #3912
Most comments of the last pull request have been considered.

Added

  • Hasse-Schmidt derivatives for polynomials

(Implemented at the request of @afkafkafk13)

Closes #3912 .

Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments about the bibliography. I am not familiar with the mathematics and will leave that for Anne to comment on.

@@ -1067,6 +1067,47 @@ @Book{Ful98
doi = {10.1007/978-1-4612-1700-8}
}

@Article{FKRS20,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this paper has been published by the AMS (https://www.ams.org/journals/mcom/2021-90-330/S0025-5718-2021-03624-8/home.html). Please cite this version instead of the arxiv one

publisher = {American Mathematical Soc.}
}

@Misc{Haze11,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be published as https://doi.org/10.3390/axioms1020149, please cite this instead.

experimental/HasseSchmidt/src/HasseSchmidt.jl Outdated Show resolved Hide resolved
primaryClass = {math.RA},
url = {https://arxiv.org/abs/1110.6108},
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bibtool is unhappy about the formatting of this file. Please see https://docs.oscar-system.org/dev/DeveloperDocumentation/documentation/#Updating-the-bibliography for more information about how to format the bibliography

@KilianBruns KilianBruns marked this pull request as draft November 6, 2024 09:13
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.49%. Comparing base (aea00d0) to head (d11fac3).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
experimental/HasseSchmidt/src/HasseSchmidt.jl 64.70% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4272      +/-   ##
==========================================
+ Coverage   84.48%   84.49%   +0.01%     
==========================================
  Files         641      642       +1     
  Lines       85427    85493      +66     
==========================================
+ Hits        72170    72239      +69     
+ Misses      13257    13254       -3     
Files with missing lines Coverage Δ
experimental/HasseSchmidt/src/HasseSchmidt.jl 64.70% <64.70%> (ø)

... and 9 files with indirect coverage changes

@afkafkafk13
Copy link
Collaborator

Algorithm and documentation look good now.
Did you already run bibtool to make changes such that everything complies to the Oscar-bibliography rules?

@fingolfin
Copy link
Member

@KilianBruns I don't understand, why is #3912 "abandoned", aren't you the author as well??

But if you really want a new branch and PR, please close the old one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants